Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecc: introduces H3 K27M mutation characteristics #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

van-lamnguyen
Copy link

@van-lamnguyen van-lamnguyen commented Jan 15, 2025

This pull request adds or modifies an ECC.

ECC: H3 K27M Mutation
This is the first introduction of the ECC H3 K27M Mutation.

Close #8
Describe the changes you have implemented and link to any relevant issues.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • You have added an entry to the CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

@van-lamnguyen van-lamnguyen self-assigned this Jan 15, 2025
@claymcleod claymcleod requested review from a team and removed request for claymcleod and mcrusch January 15, 2025 22:34
@claymcleod claymcleod added the E-MOLEC A molecular characteristic. label Jan 15, 2025
kind: binary
description:
"true":
summary: Here is a summary for the 'true' value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be filled out: how will the ECC be assigned, what will the permissible values be, and what do each of the permissible values mean.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comments. However, I am not sure what the description of the binary feature refers to.
In my understanding, it could be one of two cases:

  1. It describes the ECC, such as how we evaluate or confirm that ECC - criteria to define this ECC, for example:
    descriptions:
    "true":
    summary: Confirm by Sanger sequencing.
    "true":
    summary: confirm by RNA seq.

  2. It describe the ontology characteristics, meaning it should be in the definition of an ontology, for example:

Ontology Class: Diffuse midline glioma, H3 K27-altered
ECC:
- identifier: ECC-MOLEC-00001
name: H3 K27M Mutation
appear: true
- identifier: ECC-MOPHL-00001
name: Vascular Proliferation
appear: false
...

Please let us know your ideas or examples if possible, and correct me if I misunderstood.

Copy link

@Ssandor13 Ssandor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H3 K27M refers to a specific mutation in the histone H3 protein, where lysine at position 27 is replaced by methionine.
This mutation is primarily associated with diffuse midline gliomas (DMGs), a category of highly aggressive brain tumors that predominantly affect children but can also occur in adults.
The mutation is linked to poor prognosis, with median overall survival ranging from 10.1 to 14.4 months post-diagnosis.PMC7739048, 38102230

@van-lamnguyen
A few things to add:

  1. I think we should describe if this variant is hg38 or hg19 and what it is in the alternative ref genome as this is important to note when classifying the biomarker.
  2. what is the Human Genome Variation Society (HGVS) nomenclature?
  3. This often occurs in the H3F3A (H3.3) or HIST1H3B/C (H3.1) genes.
  4. When this variant exists, what biological function is disrupted?

@van-lamnguyen
Copy link
Author

van-lamnguyen commented Jan 30, 2025

  1. I think we should describe if this variant is hg38 or hg19 and what it is in the alternative ref genome as this is important to note when classifying the biomarker.
  2. what is the Human Genome Variation Society (HGVS) nomenclature?
  3. This often occurs in the H3F3A (H3.3) or HIST1H3B/C (H3.1) genes.
  4. When this variant exists, what biological function is disrupted?

@Ssandor13 Thank you for your comments. The comments is all about detail of the variant. As I know that we have variant database, so is that possible if we have a field to add the ID of the variant from our database?. That will help us to easily get more information if needed and keep the content consistent.

@Ssandor13
Copy link

#10 (comment)
So we have these in PeCan, but they are pretty stale and outdated and I don't recommend sharing this: https://pecan.stjude.cloud/variants/details/30241

The characteristic is having this variant specifically, so I think the content should be about the variant, if we can point out to other databases like OMIM or ClinVar that provide a details description, I think that is worth discussing internally with the team what the best practice is. I'd love to hear your thoughts on which direction we should take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-MOLEC A molecular characteristic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ECC] H3 K27M mutation
3 participants